Skip to content

Commit

Permalink
Set off-diagonal clover terms to be non-zero in clover invert test to…
Browse files Browse the repository at this point in the history
… make clover verification non trivial
  • Loading branch information
maddyscientist committed Jun 10, 2016
1 parent 6fd83bb commit da0baba
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/invert_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ int main(int argc, char **argv)
}

if (dslash_type == QUDA_CLOVER_WILSON_DSLASH) {
double norm = 0.0; // clover components are random numbers in the range (-norm, norm)
double norm = 0.2; // clover components are random numbers in the range (-norm, norm)
double diag = 1.0; // constant added to the diagonal

size_t cSize = (inv_param.clover_cpu_prec == QUDA_DOUBLE_PRECISION) ? sizeof(double) : sizeof(float);
Expand Down

3 comments on commit da0baba

@AlexVaq
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have code ready for twisted-clover (performing the inversion of the clover term in the GPU and copying back to the CPU, as you suggested), but I think I found a bug in the asymmetric preconditioning, line 336 and 344 of dirac_twisted_clover.cpp, I think it should be kappa2 and not kappa going there.

Until I perform further tests I'm suggesting everybody not to use asymmetric preconditioning. When I find out whether there is a bug or not, I'll upload the code for host twisted-clover and create a hotfix, if necessary.

I'm really annoyed about this...

@maddyscientist
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad you found this bug. One of the big motivations for having a proper dslash_test is to prevent these kind of regressions.

@AlexVaq
Copy link
Member

@AlexVaq AlexVaq commented on da0baba Jun 11, 2016 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.