Skip to content

Commit

Permalink
increase frequency of heavy-quark residual checks
Browse files Browse the repository at this point in the history
  • Loading branch information
Mathias Wagner committed May 4, 2015
1 parent 26363ac commit 9cefdb9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/inv_bicgstab_quda.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ namespace quda {
const bool use_heavy_quark_res =
(param.residual_type & QUDA_HEAVY_QUARK_RESIDUAL) ? true : false;
double heavy_quark_res = use_heavy_quark_res ? sqrt(HeavyQuarkResidualNormCuda(x,r).z) : 0.0;
int heavy_quark_check = 10; // how often to check the heavy quark residual
const int heavy_quark_check = 1; // how often to check the heavy quark residual

double delta = param.delta;

Expand Down

3 comments on commit 9cefdb9

@maddyscientist
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a hard-coded parameter? Shouldn't it be exposed to the interface?

@mathiaswagner
Copy link
Member

@mathiaswagner mathiaswagner commented on 9cefdb9 May 5, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maddyscientist
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was there in the first place because computing the heavy quark residual requires the full solution so it costs some performance. If you're just doing 25 iterations, clearly, this value it too high, but is reasonable if you're doing 100s of iterations.

Please sign in to comment.