Some adjustments for Storage Driver and SourceManager to run on the cloud #519
Conversation
🦋 Changeset detectedLatest commit: a1bdca2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
andresgutgon
force-pushed
the
fix/adjustments-for-storage-driver-and-manager
branch
2 times, most recently
from
8393d36 to
4c129f2
Compare
server We want to use some methods from these 2 packages in our Latitude cloud and we have to make it work
andresgutgon
force-pushed
the
fix/adjustments-for-storage-driver-and-manager
branch
from
4c129f2 to
a1bdca2
Compare
| const stream = await this.materializedStorage.createWriteStream(filename) | ||
| const stream = (await this.materializedStorage.createWriteStream( | ||
| filename, | ||
| )) as Writable |
There was a problem hiding this comment.
I don't understand why materializedStorage is typed a any. We must be doing something wrong.
| get isS3Driver(): boolean { | ||
| return this.type === StorageType.s3 | ||
| } | ||
|
|
There was a problem hiding this comment.
What is this for? Can't you just compare the type?
There was a problem hiding this comment.
I can, but this is nicer
There was a problem hiding this comment.
Is for the server to check if the driver is S3
There was a problem hiding this comment.
I think the an abstract parent class like this should be agnostic to its children subclasses existence.
This is not as big of a deal as if it was on the BaseConnector though, here's only two subclasses (for now). Just OCD.
There was a problem hiding this comment.
Yep pure ocd in relation to the size of the driver code xD
Describe your changes
We want to use some methods from these 2 packages in our Latitude cloud and we have to make it work.
TODO