-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for filtering diagnostics #655
Conversation
Codecov Report
@@ Coverage Diff @@
## master #655 +/- ##
==========================================
- Coverage 78.72% 78.16% -0.56%
==========================================
Files 119 119
Lines 11360 11504 +144
==========================================
+ Hits 8943 8992 +49
- Misses 2417 2512 +95
Continue to review full report at Codecov.
|
Looks good! What happens if both (I can't test at the moment since for some reason texlab no longer respects the options I set in my Neovim config. I'll have to bisect that -- has anything relevant changed in recent time?) |
The allowed patterns are applied first, the results are then filtered by the ignored patterns.
I think, this may be caused by ae4a126. |
Might be good to document that?
Hmmm, I don't think so, as I can reproduce that on 3.3.0. Must be an issue on my side. (Funnily, it only seems to affect texlab, though.) |
Yeah, definitely 👍
This might also be related to bd85205 (especially if the client does not send all config properties). |
This PR provides support for filtering the diagnostics by providing two new settings
texlab.diagnostics.allowedPatterns
andtexlab.diagnostics.ignoredPatterns
. Both take a list of regular expressions that are matched against themessage
.Example: