Undefined reference #923

yashamon · 2023-09-04T19:00:52Z

This issue appeared recently. Probably last release. All citations are now marked undefined reference. The location of bib is standard: ~/texmf/bibtex/bib
The document compiles without issues with all references intact.

Platform: Win11 release, neovim 9.1

pfoerster · 2023-09-10T07:01:33Z

@yashamon Thanks for the report! Does kpsewhich find the bibliography and does texlab (check if texlab reports a document link for the \bibliography/\addbibresource command)? As a test, can you try adding the directory to the BIBINPUTS environment variable, please?

firubat · 2023-09-22T07:45:46Z

@pfoerster This bug happens to me too. Neovim 0.9.2 on linux mint.
kpsewhich finds the bibliography.
Can you explain how to do the check in texlab?

yashamon · 2023-09-22T17:23:40Z

I thought I also replied. In my case kpsewhich also finds the bib file. We are only using the LSP server so I am not sure how to troubleshoot further.

pfoerster · 2023-09-23T06:46:51Z

@yashamon @firubat
Can you try triggering a "goto definition" on the \addbibresource or \bibliography command? If it does not open the file, then the server does not find the file.

Can you also try the BIBINPUTS test, please (note that you cannot use ~ inside the variable)?

As a test, can you try adding the directory to the BIBINPUTS environment variable, please?

firubat · 2023-09-23T17:25:42Z

@pfoerster So seems that if the bib file is in the same folder as the tex file, it is recognized by texlab. But if the bib file is in a different folder in the BIBINPUTS path (which is the way I like to do it), it is not recognized (the goto definition won't open the file in this case).

yashamon · 2023-09-23T20:08:27Z

Same for me, the issue goes away if the bib file is local.

…

On Sat, Sep 23, 2023 at 11:25 AM firubat ***@***.***> wrote: @pfoerster <https://github.com/pfoerster> So seems that if the bib file is in the same folder as the tex file, it is recognized by texlab. But if the bib file is in a different folder in the BIBINPUTS path (which is the way I like to do it), it is not recognized (the goto definition won't open the file in this case). — Reply to this email directly, view it on GitHub <#923 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABQGIZSYUOFMZNBXNA6H44LX34LSBANCNFSM6AAAAAA4KYRURI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

See #923.

pfoerster · 2023-09-24T20:21:03Z

@yashamon @firubat Can you try b2a49d0, please? With this changeset, the server should be able to find the bibliography.

naibaf0 · 2023-09-25T06:48:52Z

I have the same error even if the actual scenario seems different and just tried the new commit. It does find a bibliography file in the tex distribution and uses it now, however even in the case where a local file with the same name is present.

in my case I do have a local file bibliography.bib in my project which should be used and when running with this patch, goto definition (of the bibliography) will now offer to go to /usr/share/doc/texlive/bibtex/newcastle-bst/bibliography.bib in addition to my local file. It also offers autocompletion for citations from both files.

So I am guessing there is still some logic missing to prefer a local file over the one from the tex distribution tree.

firubat · 2023-09-25T08:10:22Z

Can you try b2a49d0, please?

I must admit that I don't know how to do that, I'm using texlab in neovim via Mason, and I don't know how to tell it to use a specific commit which is outside the releases cycle...

naibaf0 · 2023-09-25T08:19:59Z

@firubat for me mason saves the binary for texlab in ~/.local/share/nvim/mason/packages/texlab. I think that is the default, but not completely sure.
If you build texlab on the the specified commit locally, you can copy the newly built binary into the location where mason saves it and it will be used in neovim.

pfoerster · 2023-09-25T19:55:11Z

@naibaf0 Thanks for trying out the commit.

So I am guessing there is still some logic missing to prefer a local file over the one from the tex distribution tree.

This should be fixed now. I will publish a new release soon.

firubat · 2023-11-08T20:54:43Z

Hi @pfoerster , for some reason this is still an issue for me (current version 5.11.0)

yashamon · 2023-11-08T22:01:19Z

Is it already in the release version? I have no way to compile commits, well I would prefer not to.

…

On Wed, Nov 8, 2023 at 2:54 PM firubat ***@***.***> wrote: Hi @pfoerster <https://github.com/pfoerster> , for some reason this is still an issue for me (current version 5.11.0) — Reply to this email directly, view it on GitHub <#923 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABQGIZRPF7WICVFTJOUWXO3YDPWR5AVCNFSM6AAAAAA4KYRURKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBSGY2TSOJWG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

pfoerster · 2023-11-12T12:53:41Z

@yashamon

Is it already in the release version?

Yes, this changeset is included with v5.9.0.

@firubat Is the missing bibliography contained in your home directory?

yashamon · 2023-11-12T19:12:50Z

In that case I am still experiencing the issue. My bib is in the supposedly standard global directory. If bib file is moved to local directory the issue goes away.

…

On Sun, Nov 12, 2023 at 6:53 AM Patrick Förster ***@***.***> wrote: @yashamon <https://github.com/yashamon> Is it already in the release version? Yes, this changeset is included with v5.9.0 <https://github.com/latex-lsp/texlab/blob/master/CHANGELOG.md#590---2023-08-06> . @firubat <https://github.com/firubat> Is the missing bibliography contained in your home directory? — Reply to this email directly, view it on GitHub <#923 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABQGIZXOFDCY5BRKF5UTJZLYEDBGBAVCNFSM6AAAAAA4KYRURKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBXGEYTSMJYGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

firubat · 2023-11-12T19:13:29Z

@pfoerster It's in ~/Dropbox. Which I manually added to the BIBINPUTS variable

firubat · 2023-11-12T20:30:18Z

I tried to put it also in /usr/share/texmf and /usr/local/share/texmf but to no avail. Only if it's in the same directory as the tex file.

## [5.11.0] - 2023-11-05 ### Added - Add `texlab.inlayHints.labelDefinitions` and `texlab.inlayHints.labelReferences` options ([#753](latex-lsp/texlab#753)) - Display inlay hints for label references by default ([#753](latex-lsp/texlab#753)) ### Fixed - Moving the build logs to the recycle bin will now clear the diagnostics ([texlab-vscode/#825](latex-lsp/texlab-vscode#825)) - Fix false positive when reporting syntax errors for BibTeX accents ([#945](latex-lsp/texlab#945)) ## [5.10.1] - 2023-10-10 ### Fixed - Fix regression when renaming commands ([#936](latex-lsp/texlab#936)) ## [5.10.0] - 2023-09-30 ### Added - Allow passing additional arguments to `ChkTeX` using `texlab.chktex.additionalArgs` ([#927](latex-lsp/texlab#927)) ### Fixed - Fix loading bibliographies from `kpathsea` search path ([#923](latex-lsp/texlab#923)) - Don't report duplicate results when using goto definition on includes ([#924](latex-lsp/texlab#924)) - Fix project detection when there exist files with the same name ([#923](latex-lsp/texlab#923)) - Do not report parse errors with `$` in paths ([#931](latex-lsp/texlab#931)) ## [5.9.2] - 2023-08-14 ### Fixed - Don't crash when using comments inside `\include`-like commands ([#919](latex-lsp/texlab#919)) - Folding ranges include only the contents instead of the entire range of the structure. For example, the folding range of an environment will start after the `\begin` and stop before the `\end` ([#915](latex-lsp/texlab#915)) ## [5.9.1] - 2023-08-11 ### Fixed - Improve performance when completing BibTeX entries ([#493](latex-lsp/texlab#493)) - Don't report unused entries for very large bibliographies - Avoid redundant reparses after saving documents ## [5.9.0] - 2023-08-06 ### Added - Use bibliographies found in `BIBINPUTS` environment variable ([#493](latex-lsp/texlab#493)) - Add `texlab.build.pdfDirectory` setting ([#911](latex-lsp/texlab#911)) ### Fixed - Fix search path for aux files when using `\include` instead of `\input` ([#906](latex-lsp/texlab#906)) ## [5.8.0] - 2023-07-30 ### Added - Report diagnostics for unused and undefined labels - Report diagnostics for unused BibTeX entries and undefined citations - Report diagnostics for duplicate BibTeX entries - Report diagnostics for duplicate labels - Add `texlab.build.auxDirectory` and `texlab.build.logDirectory` settings ([#906](latex-lsp/texlab#906)) ### Deprecated - Deprecate `texlab.auxDirectory` in favor of `texlab.build.auxDirectory` ### Fixed - Fix parsing paths with `|` ([#568](latex-lsp/texlab#568)) - Fix parsing LaTeX identifiers with `=` ([#568](latex-lsp/texlab#568))

Zeta611 · 2023-11-21T08:50:27Z

I have this issue when there are (at least) Korean characters in the path.

I have a .bib file in a local directory where the .tex file lives in.
If the directory contains Korean characters, the LSP shows Undefined reference error, but when I move the directory to a path without Korean characters, the error goes away.

This probably means the directory is not properly handled for CJK characters.

andrasbarany · 2024-02-14T10:31:52Z

I am also having this issue with version 5.12.3 in both nvim and nvim-qt. If I copy or link the bibliography file to the local directory, the error disappears. BIBINPUTS is set to the folder containing the .bib file but is apparently ignored.

I'm using my distribution's texlab binary, but changing to the one installed using :LspInstall in nvim doesn't help either.

Here's the output of :LspInfo

 Press q or <Esc> to close this window. Press <Tab> to view server doc.
 
 Language client log: /home/ba/.local/state/nvim/lsp.log
 Detected filetype:   tex
 
 1 client(s) attached to this buffer: 
 
 Client: texlab (id: 1, bufnr: [1])
 	filetypes:       tex, plaintex, bib
 	autostart:       true
 	root directory:  /home/ba
 	cmd:             /usr/bin/texlab
 
 Configured servers list: texlab, marksman

soficshift · 2024-04-13T07:28:28Z

Perhaps it's related to the tilde expansion?

\addbibresource{~/Zotero/bibs/all.bib}

wasn't working for me, but

\addbibresource{/home/lucas/Zotero/bibs/all.bib}

does.

yashamon · 2024-04-13T18:14:21Z

I think we are all using absolute paths.

…

On Sat, Apr 13, 2024, 03:28 Lucas ***@***.***> wrote: Perhaps it's related to the tilde expansion? \addbibresource{~/Zotero/bibs/all.bib} wasn't working for me, but \addbibresource{/home/lucas/Zotero/bibs/all.bib} does. — Reply to this email directly, view it on GitHub <#923 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABQGIZUJ4MH7VJVAS477VRTY5DNDDAVCNFSM6AAAAAA4KYRURKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJTGU2TMNZTG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

juntuu · 2024-06-24T17:29:35Z

tl;dr Percent encoding in paths may have different casing of hex characters (a-f or A-F), which leads to mismatches later.

I have this issue when there are (at least) Korean characters in the path.

I have a .bib file in a local directory where the .tex file lives in. If the directory contains Korean characters, the LSP shows Undefined reference error, but when I move the directory to a path without Korean characters, the error goes away.

This probably means the directory is not properly handled for CJK characters.

I also noticed this issue with some characters in the path. (using neovim as the LSP client)

I did some investigation and found out that (at least part of) the cause was the percent encoding of URIs.

The LSP messages from the client contain URIs, which were percent encoded with lowercase hex. However, the URI for loaded file is constructed from a Rust Path, see:

texlab/crates/base-db/src/workspace.rs

Line 95 in 3d70feb

let uri = Url::from_file_path(path).unwrap();

That from_file_path method uses uppercase hex for percent encoding, which causes the URIs to not match later.

Another place where the bibliography path is constructed is:

texlab/crates/base-db/src/deps/graph.rs

Line 162 in 3d70feb

util::expand_relative_path(file_name, &start.root.src_dir, workspace.folders())

This joins the relative path with the directory component, which may come from the LSP client. Thus the joined path may have different casing for the hex in percent encoding, depending on the LSP client.

I think the first is loading the bib file as part of the workspace, and the latter is resolving the path given to addbibresource command. So the two URIs for the same file may end up being different.

(Relative paths seem to work, when the encoded part is within it)

After this I also noticed that traversing back the encoded parts of the path "worked" again. (Which kind of makes sense.)

Under path /home/me/ä/, where ä will be encoded.

Doesn't work

\addbibresource{references.bib}
\cite{test}

"Works"

\addbibresource{../ä/references.bib}
\cite{test}

Solutions?

I'm not familiar with the project or the code, so can't say what would make sense.

Could that be part of normalize_uri?

texlab/crates/texlab/src/util.rs

Line 9 in 3d70feb

pub fn normalize_uri(uri: &mut lsp_types::Url) {

See #923.

pfoerster · 2024-06-29T10:32:17Z

@juntuu Thanks for digging into this. I have created #1148, which extends normalize_uri.

See #923.

Improves detection of included files when non-ASCII characters are used by normalizing the casing of the percent encoding found in URIs. See #923.

## [5.21.0] - 2024-10-26 ### Added - Support starred variants in "Go to References" ([#1234](latex-lsp/texlab#1234)) - Add `texlab.latexindent.replacement` setting to allow passing a replacement flag to `latexindent` ([#1222](latex-lsp/texlab#1222)) - Don't require a label to show section numbers for document symbols ([#910](latex-lsp/texlab#910)) - Support navigating to files that are part of the `TEXINPUTS` similar to `BIBINPUTS` ([#1228](latex-lsp/texlab#1228)) ### Fixed - Fix opening `untitled` documents ([#1242](latex-lsp/texlab#1242)) - Handle `\bibitem` when checking for undefined references ([#1171](latex-lsp/texlab#1171)) - Fix false-positive syntax error when using a command inside a `\label` ([#879](latex-lsp/texlab#879)) ## [5.20.0] - 2024-10-08 ### Added - Add `texlab.inlayHints.maxLength` setting to allow limiting inlay hint text length ([#1212](latex-lsp/texlab#1212)) - Allow suppressing diagnostics using `% texlab: ignore` magic comments ([#1211](latex-lsp/texlab#1211)) ### Fixed - Fix enabling `texlab.build.useFileList` setting - Make "Goto Definition" work correctly with starred commands ([#1197](latex-lsp/texlab#1197)) ## [5.19.0] - 2024-07-08 ### Added - Add `texlab.build.useFileList` setting to allow controlling whether to use the `.fls` files ### Changed - Disable using `.fls` files for project detection by default ## [5.18.0] - 2024-07-06 ### Added - Parse `.fls` files to make the project detection more reliable ([#1145](latex-lsp/texlab#1145)) ### Fixed - Fix parsing commands with unicode characters inside BibTeX entries ([#1147](latex-lsp/texlab#1147)) - Improve detection of included files when non-ASCII characters are used ([#923](latex-lsp/texlab#923)) - Fix resolving includes starting from files included using `\subimport` ([#1145](latex-lsp/texlab#1145)) ## [5.17.0] - 2024-06-23 ### Added - Add label commands from `zref` and `zref-clever` to the list of default label commands ([#1140](latex-lsp/texlab#1140)) - Add `texlab.experimental.labelDefinitionPrefixes` and `texlab.experimental.labelReferencePrefixes` options ([#1139](latex-lsp/texlab#1139))

pfoerster added the bug Something isn't working label Sep 10, 2023

pfoerster added a commit that referenced this issue Sep 24, 2023

Fix loading bibliographies from TeX distro

b2a49d0

See #923.

pfoerster mentioned this issue Sep 25, 2023

Fix project detection with duplicate file names #933

Merged

pfoerster closed this as completed in #933 Sep 25, 2023

pfoerster reopened this Nov 12, 2023

pfoerster added a commit that referenced this issue Jun 29, 2024

Handle URIs with lower case percent encoding

b556d5f

See #923.

pfoerster mentioned this issue Jun 29, 2024

Handle URIs with lower case percent encoding #1148

Merged

pfoerster added a commit that referenced this issue Jun 29, 2024

Handle URIs with lower case percent encoding

02143c1

See #923.

pfoerster added a commit that referenced this issue Jun 29, 2024

Handle URIs with lower case percent encoding

cf438d2

See #923.

pfoerster added a commit that referenced this issue Jun 29, 2024

Handle URIs with lower case percent encoding

6aa43d5

See #923.

pfoerster added a commit that referenced this issue Jun 29, 2024

Handle URIs with lower case percent encoding

b83808d

See #923.

pfoerster added a commit that referenced this issue Jun 29, 2024

Handle URIs with lower case percent encoding (#1148)

bd8ea69

Improves detection of included files when non-ASCII characters are used by normalizing the casing of the percent encoding found in URIs. See #923.

BrewTestBot mentioned this issue Jul 6, 2024

texlab 5.18.0 Homebrew/homebrew-core#176537

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Undefined reference #923

Undefined reference #923

yashamon commented Sep 4, 2023

pfoerster commented Sep 10, 2023

firubat commented Sep 22, 2023

yashamon commented Sep 22, 2023

pfoerster commented Sep 23, 2023

firubat commented Sep 23, 2023

yashamon commented Sep 23, 2023 via email

pfoerster commented Sep 24, 2023

naibaf0 commented Sep 25, 2023

firubat commented Sep 25, 2023

naibaf0 commented Sep 25, 2023

pfoerster commented Sep 25, 2023

firubat commented Nov 8, 2023

yashamon commented Nov 8, 2023 via email

pfoerster commented Nov 12, 2023

yashamon commented Nov 12, 2023 via email

firubat commented Nov 12, 2023 •

edited

Loading

firubat commented Nov 12, 2023

Zeta611 commented Nov 21, 2023

andrasbarany commented Feb 14, 2024 •

edited

Loading

soficshift commented Apr 13, 2024

yashamon commented Apr 13, 2024 via email

juntuu commented Jun 24, 2024

pfoerster commented Jun 29, 2024

Undefined reference #923

Undefined reference #923

Comments

yashamon commented Sep 4, 2023

pfoerster commented Sep 10, 2023

firubat commented Sep 22, 2023

yashamon commented Sep 22, 2023

pfoerster commented Sep 23, 2023

firubat commented Sep 23, 2023

yashamon commented Sep 23, 2023 via email

pfoerster commented Sep 24, 2023

naibaf0 commented Sep 25, 2023

firubat commented Sep 25, 2023

naibaf0 commented Sep 25, 2023

pfoerster commented Sep 25, 2023

firubat commented Nov 8, 2023

yashamon commented Nov 8, 2023 via email

pfoerster commented Nov 12, 2023

yashamon commented Nov 12, 2023 via email

firubat commented Nov 12, 2023 • edited Loading

firubat commented Nov 12, 2023

Zeta611 commented Nov 21, 2023

andrasbarany commented Feb 14, 2024 • edited Loading

soficshift commented Apr 13, 2024

yashamon commented Apr 13, 2024 via email

juntuu commented Jun 24, 2024

pfoerster commented Jun 29, 2024

firubat commented Nov 12, 2023 •

edited

Loading

andrasbarany commented Feb 14, 2024 •

edited

Loading