[Tests] Integrate fake stake tests into parent test suite

This integrates each of the 5 test scripts into the parent test suite so
 they can be run from within `test_runner.py` (or still individually).
 One prominent benefit to this is that the 5 tests are now included when
 generating code coverage reports with `make cov`

`stratisx-notingatstake.py` and `pivx_fake_stake.py` are removed as the
former was a stale leftover from prior to our own test scripts, and the
latter is now redundant.

test/functional/fake_stake/base_test.py

@@ -15,7 +15,7 @@
 from test_framework.script import CScript, OP_CHECKSIG
 from test_framework.util import hash256, bytes_to_hex_str, hex_str_to_bytes, connect_nodes_bi, p2p_port
 
-from util import TestNode, create_transaction, utxo_to_stakingPrevOuts, dir_size
+from .util import TestNode, create_transaction, utxo_to_stakingPrevOuts, dir_size
 ''' -------------------------------------------------------------------------
 PIVX_FakeStakeTest CLASS ----------------------------------------------------
 

test/functional/fake_stake/test05.py → test/functional/p2p_pos_doublespend.py

@@ -1,16 +1,19 @@
 #!/usr/bin/env python3
-# -*- coding: utf-8 -*-
+# Copyright (c) 2019 The PIVX Core developers
+# Distributed under the MIT software license, see the accompanying
+# file COPYING or http://www.opensource.org/licenses/mit-license.php.
+
 '''
 Covers the scenario of a valid PoS block with a valid coinstake transaction where the
 coinstake input prevout is double spent in one of the other transactions in the same block.
 '''
 
 from time import sleep
 
-from base_test import PIVX_FakeStakeTest
+from fake_stake.base_test import PIVX_FakeStakeTest
 
 
-class Test_05(PIVX_FakeStakeTest):
+class PoSDoubleSpend(PIVX_FakeStakeTest):
 
     def run_test(self):
         self.description = "Covers the scenario of a valid PoS block with a valid coinstake transaction where the coinstake input prevout is double spent in one of the other transactions in the same block."
@@ -46,3 +49,6 @@ def run_test(self):
             raise AssertionError("TEST FAILED")
 
         self.log.info("%s PASSED" % self.__class__.__name__)
+
+if __name__ == '__main__':
+    PoSDoubleSpend().main()

test/functional/fake_stake/test01.py → test/functional/p2p_pos_fakestake.py

@@ -1,14 +1,17 @@
 #!/usr/bin/env python3
-# -*- coding: utf-8 -*-
+# Copyright (c) 2019 The PIVX Core developers
+# Distributed under the MIT software license, see the accompanying
+# file COPYING or http://www.opensource.org/licenses/mit-license.php.
+
 '''
 Covers the scenario of a PoS block where the coinstake input prevout is already spent.
 '''
 
 from time import sleep
 
-from base_test import PIVX_FakeStakeTest
+from fake_stake.base_test import PIVX_FakeStakeTest
 
-class Test_01(PIVX_FakeStakeTest):
+class PoSFakeStake(PIVX_FakeStakeTest):
 
     def run_test(self):
         self.description = "Covers the scenario of a PoS block where the coinstake input prevout is already spent."
@@ -50,3 +53,6 @@ def run_test(self):
             raise AssertionError("TEST FAILED")
 
         self.log.info("%s PASSED" % self.__class__.__name__)
+
+if __name__ == '__main__':
+    PoSFakeStake().main()

test/functional/fake_stake/test02.py → test/functional/p2p_pos_fakestake_accepted.py

@@ -1,15 +1,18 @@
 #!/usr/bin/env python3
-# -*- coding: utf-8 -*-
+# Copyright (c) 2019 The PIVX Core developers
+# Distributed under the MIT software license, see the accompanying
+# file COPYING or http://www.opensource.org/licenses/mit-license.php.
+
 '''
 Covers the scenario of a valid PoS block where the coinstake input prevout is spent on main chain,
 but not on the fork branch. These blocks must be accepted.
 '''
 
 from time import sleep
 
-from base_test import PIVX_FakeStakeTest
+from fake_stake.base_test import PIVX_FakeStakeTest
 
-class Test_02(PIVX_FakeStakeTest):
+class PoSFakeStakeAccepted(PIVX_FakeStakeTest):
 
     def run_test(self):
         self.description = "Covers the scenario of a valid PoS block where the coinstake input prevout is spent on main chain, but not on the fork branch. These blocks must be accepted."
@@ -52,3 +55,6 @@ def run_test(self):
             raise AssertionError("TEST FAILED")
 
         self.log.info("%s PASSED" % self.__class__.__name__)
+
+if __name__ == '__main__':
+    PoSFakeStakeAccepted().main()

test/functional/fake_stake/test03.py → test/functional/p2p_zpos_fakestake.py

@@ -1,5 +1,8 @@
 #!/usr/bin/env python3
-# -*- coding: utf-8 -*-
+# Copyright (c) 2019 The PIVX Core developers
+# Distributed under the MIT software license, see the accompanying
+# file COPYING or http://www.opensource.org/licenses/mit-license.php.
+
 '''
 Covers the scenario of a zPoS block where the coinstake input is a zerocoin spend
 of an already spent coin.
@@ -9,9 +12,9 @@
 
 from test_framework.authproxy import JSONRPCException
 
-from base_test import PIVX_FakeStakeTest
+from fake_stake.base_test import PIVX_FakeStakeTest
 
-class Test_03(PIVX_FakeStakeTest):
+class zPoSFakeStake(PIVX_FakeStakeTest):
 
     def run_test(self):
         self.description = "Covers the scenario of a zPoS block where the coinstake input is a zerocoin spend of an already spent coin."
@@ -98,3 +101,6 @@ def run_test(self):
             raise AssertionError("TEST FAILED")
 
         self.log.info("%s PASSED" % self.__class__.__name__)
+
+if __name__ == '__main__':
+    zPoSFakeStake().main()

test/functional/fake_stake/test04.py → test/functional/p2p_zpos_fakestake_accepted.py

@@ -1,14 +1,17 @@
 #!/usr/bin/env python3
-# -*- coding: utf-8 -*-
+# Copyright (c) 2019 The PIVX Core developers
+# Distributed under the MIT software license, see the accompanying
+# file COPYING or http://www.opensource.org/licenses/mit-license.php.
+
 '''
 Performs the same check as in Test_02 verifying that zPoS forked blocks that stake a zerocoin which is spent on mainchain on an higher block are still accepted.
 '''
 
 from test_framework.authproxy import JSONRPCException
-from base_test import PIVX_FakeStakeTest
+from fake_stake.base_test import PIVX_FakeStakeTest
 from time import sleep
 
-class Test_04(PIVX_FakeStakeTest):
+class zPoSFakeStakeAccepted(PIVX_FakeStakeTest):
 
 
     def set_test_params(self):
@@ -109,3 +112,6 @@ def run_test(self):
             raise AssertionError("TEST FAILED")
 
         self.log.info("%s PASSED" % self.__class__.__name__)
+
+if __name__ == '__main__':
+    zPoSFakeStakeAccepted().main()