Support TLS operation with EdDSA keys #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jakuje
force-pushed
the
tls-eddsa
branch
2 times, most recently
from
1a56cfd
to
31d5aca
Compare
Fixes: latchset#461 Signed-off-by: Jakub Jelen <[email protected]>
The EdDSA signature verification causes infinite recursion in softhsm when the OPENSSL_CONF is used to force all operations to token because the SoftHSM Is using the EVP_PKEY API to implement the EdDSA signature and verification which is recursively routed back to the pkcs11-provider. The workaround is to set the propquery on the openssl cli, which will not propagate to the softhsm context. Signed-off-by: Jakub Jelen <[email protected]>
Signed-off-by: Jakub Jelen <[email protected]>
|
Everything looks good, merging, thanks a bunch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It turned out the import of EdDSA keys went through the ECDSA code paths which failed down the road. After fixing that, the TLS tests turned out to go into infinite recursion in softhsm where the softhsm operation would call back to the pkcs11 provider code making everything explode. The workaround is to use the propquery on the openssl tools cli, which looks like working ok.
Fixes #461.
Checklist
Reviewer's checklist: