Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HOWTO.md #411

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Update HOWTO.md #411

merged 1 commit into from
Jul 2, 2024

Conversation

karamellpelle
Copy link
Contributor

Elaborating some details

Description

I added some small clarifications/explanations about how to use provider-pkcs11. These explanations would have saved me from some hours of problems while setting up provider_pkcs11 on my system.

I tried to write these additions concise and in similar wording.

Checklist

  • Code modified for feature
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • This feature/change has adequate documentation added
  • Code conform to coding style that today cannot yet be enforced via the check style test
  • Commits have short titles and sensible commit messages
  • Coverity Scan has run if needed (code PR) and no new defects were found

Copy link
Member

@simo5 simo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it is a welcome addition to our docs. Just one minor change required.

HOWTO.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@karamellpelle karamellpelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improved sentence

@simo5
Copy link
Member

simo5 commented Jul 1, 2024

It would be nice if you could squash the two commits, if you can't do that let me know and I will deal with it.

@karamellpelle
Copy link
Contributor Author

karamellpelle commented Jul 1, 2024

It would be nice if you could squash the two commits, if you can't do that let me know and I will deal with it.

Yes, please do that (and modify the commit even more if you need to). I tried to squash (git rebase -i HEAD~2 + and push back to my fork repository), but I wasn't able to make it work. I've never done squashing before, and I have little experience with pull request, but it is fun to learn new workflows so I can be better at contributing to the open source community.

Thanks!

EDIT: GitHub has a good resource to learn more about collaborations and PR; I will have a look at that.

Signed-off-by: karamellpelle <[email protected]>
@simo5
Copy link
Member

simo5 commented Jul 2, 2024

I forced pushed the sqashed commits to your main branch.
You probably want to git pull --rebase locally, or something

@simo5 simo5 merged commit 3636619 into latchset:main Jul 2, 2024
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants