Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup old code and add toggle for on/off #2

Merged
merged 4 commits into from
Mar 27, 2019
Merged

Cleanup old code and add toggle for on/off #2

merged 4 commits into from
Mar 27, 2019

Conversation

bradtaylorsf
Copy link
Contributor

@dano-optimizely when you get a moment can you do a few things?

  1. Style the popup.html to make it look a little better. Right now there is only the on/off toggle but we could have a more robust menu later
  2. I removed some of the hover states because they were affecting the site. Please verify I caught them all
  3. Can you update the edit button so that only the button is clickable? Right now the entire area is clickable making it impossible to browse the site when using the sidekick

@bradtaylorsf bradtaylorsf merged commit e70f135 into master Mar 27, 2019
@bradtaylorsf bradtaylorsf deleted the bt/cleanup branch March 27, 2019 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@altruity altruity Awaiting requested review from altruity

@dano-optimizely dano-optimizely Awaiting requested review from dano-optimizely

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bradtaylorsf @dano-optimizely