Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field name visible on hover #18

Merged
merged 1 commit into from
Aug 27, 2020
Merged

Field name visible on hover #18

merged 1 commit into from
Aug 27, 2020

Conversation

altruity
Copy link
Contributor

Just for demo.
Will update to use x/y positional coordinates within the viewport.

@altruity altruity requested a review from bradtaylorsf April 30, 2020 01:47
Copy link
Contributor

@bradtaylorsf bradtaylorsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ready or still in draft?

@altruity
Copy link
Contributor Author

altruity commented May 6, 2020

This will function as-is by inserting an element that is absolutely positioned. Should look fine in most cases, but possibility exists that some sibling element has styling on last-child.

A more bullet-proof approach might be using a tooltip positioning library, such as Popperjs, to do that by coordinates. [demo here]

@bradtaylorsf bradtaylorsf marked this pull request as ready for review July 27, 2020 21:58
@altruity altruity requested a review from bradtaylorsf August 20, 2020 16:02
@bradtaylorsf bradtaylorsf merged commit 2ecb194 into master Aug 27, 2020
@bradtaylorsf bradtaylorsf deleted the sidekick-field-name branch August 27, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants