Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lasso.js should not mangle page bundle names #48

Closed
philidem opened this issue May 16, 2015 · 0 comments
Closed

Lasso.js should not mangle page bundle names #48

philidem opened this issue May 16, 2015 · 0 comments

Comments

@philidem
Copy link
Contributor

This code is being used to "sanitize" the bundle name:

var pageBundleName = pageName.replace(/^[^A-Za-z0-9_\-\.]*/g, '');

This is effectively removing "special characters" at the start of the page name when forming the bundle name. However, there is no reason to sanitize the bundle name. The mangling of the bundle name prevents predictable lookup of information from the LassoPageResult after the lassoPage operation completes.

patrick-steele-idem added a commit that referenced this issue May 18, 2015
Fixes #48: Lasso.js should not mangle page bundle names
patrick-steele-idem added a commit that referenced this issue May 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant