Automatically update eurusd.csv if required + introduction of unit tests #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @laroche,
I don't like the necessity to update the eurusd.csv file manually if it is outdated, so I adjusted the code to automatically download a current version if it is required depending on the transaction history data.
Additionally I redesigned the code to a more class based approached which allows to implement unit tests. Some functionality has been moved to a TastytradeHelper class. I started implementing a couple of unit tests for its methods.
From my point of view that make future code changes much more easier, if developers can check if unit tests are still running without errors. I'd love to see unit tests in the future which check that certain transaction history inputs deliver a certain tax data output.
Please review my code changes.