Support for new Tastytrade data format #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 23, 2024
|
I added a small additional change which removes the pandas warning on value access by position. |
|
Working for me. Thank you! |
|
Hello Heiko, very nice patches. I'll merge them and hope to find some time for additional improvements. best regards, Florian La Roche |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @laroche, I've incorporated the changes for support of the new Tastytrade history data format.
Additionally I added a VSCode Debugger launch.json file and started a folder with test data with might later on be used for implementing automated Unit Tests.
I also added multiplier for some currencies.
Please review my changes.