setup.cfg: Replace deprecated license_file with license_files #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the deprecated `license_file` key with `license_files`. The latter has the same semantics and is available since setuptools 42.0.0 (that lark already requires).
|
Is there a reason to change this? Is |
Right now it triggers verbose deprecation warnings that trigger our QA pipelines.
Hard to tell. I've asked setuptools a more general question about timeline for dropping deprecated stuff, and got no answer. However, they definitely did remove some deprecated stuff in the past. |
Fair enough. |
|
Thanks for bearing with me. This is really appreciated. |
|
No problem, thanks for making Lark a tiny bit better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the deprecated
license_filekey withlicense_files. The latter has the same semantics and is available since setuptools 42.0.0 (that lark already requires).