Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): allow laravel/container:^7.0 #922

Merged
merged 1 commit into from
Mar 13, 2020
Merged

chore(deps): allow laravel/container:^7.0 #922

merged 1 commit into from
Mar 13, 2020

Conversation

ellisio
Copy link
Contributor

@ellisio ellisio commented Mar 13, 2020

This will allow users to install this package with laravel/vapor-cli.

This is needed for the following scenarios:

composer global require laravel/valet
composer global require laravel/vapor-cli # fails
composer global require laravel/vapor-cli
composer global require laravel/valet # fails

@drbyte
Copy link
Contributor

drbyte commented Mar 13, 2020

Is there a need to add a 7.0 option for tightenco/collect as well?

@ellisio
Copy link
Contributor Author

ellisio commented Mar 13, 2020

@drbyte Nope. I am currently using my fork until this is merged and everything works fine.

Modify your ~/.composer/composer.json and add:

"repositories": [
   {
       "type": "vcs",
       "url": "https://github.com/ellisio/valet.git"
   }
]

Then run:

composer global require laravel/valet:dev-test

This will install Valet with the ^7.0 requirement using my fork. Then you can install vapor-cli.

@mattstauffer
Copy link
Collaborator

Whoops! Great catch--thanks!

@mattstauffer mattstauffer merged commit aae0d99 into laravel:master Mar 13, 2020
@ellisio ellisio deleted the chore/deps/laravel/container branch March 16, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants