New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOME Autoloader #767

Merged

mattstauffer merged 1 commit into laravel:master from furey:feature/home-autoloader

Apr 12, 2019

Contributor

furey commented Apr 12, 2019 •

edited

Loading

Overview

This PR adds a HOME path to the list of potential autoloaders at the head of Valet's CLI file.

Background

To work on third-party open source PRs, I use franzliedke/studio (installed globally).

My studio workflow for Valet PRs is to…

Clone laravel/valet locally
Create a new PR branch (e.g. new-pr-branch)
From within ~/.composer run studio load [path to local laravel/valet clone]
Open ~/.composer/composer.json
Update "laravel/valet": [version] to "laravel/valet": "dev-new-pr-branch"
Run composer global update laravel/valet

After stepping through my workflow…

Without this PR, valet exits as no autoloader path can be found.
With this PR, valet boots normally as the HOME autoloader path is found.

I understand…

This PR may be of no use to Windows users.
My PR workflow is probably an edge case.

Cheers!

🤓🤞


          Added HOME Composer autoload path to head of Valet CLI file.

2e4b165

Contributor

drbyte commented Apr 12, 2019

Makes sense. I'm good with this. 👍

mattstauffer merged commit 6f70c9a into laravel:master

furey deleted the feature/home-autoloader branch

April 13, 2019 02:44

Contributor Author

furey commented Apr 13, 2019

Thank you!

🤓👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet