Add JSON:API support for Drupal #705
Conversation
|
@samgranger Since I don't use Drupal it's hard to check this. Could you ask some other Drupal/Valet folks to check this out and give feedback here for me? |
|
@samgranger Ping--anyone you know who can test it who's a Drupal dev using Valet? |
There was a problem hiding this comment.
@samgranger @mattstauffer Tested. This worked for me. Fixes #771. LGTM.
| @@ -57,7 +57,7 @@ public function frontControllerPath($sitePath, $siteName, $uri) | |||
| { | |||
| $sitePath = $this->addSubdirectory($sitePath); | |||
|
|
|||
| if (!isset($_GET['q']) && !empty($uri) && $uri !== '/') { | |||
| if (!isset($_GET['q']) && !empty($uri) && $uri !== '/' && strpos($uri, '/jsonapi/') === false) { | |||
There was a problem hiding this comment.
👋 I'm the JSON:API maintainer in Drupal.
Bear in mind that the /jsonapi path is configurable. So is anyone changes the defaults this may break.
There was a problem hiding this comment.
@e0ipso oh yeah. I completely missed that. Funny thing is, IIRC, I wrote the patch to make this configurable. 😄
There was a problem hiding this comment.
Thanks for sharing, y'all! Sooo.. is there any way to fix this driver or is that just not going to be possible since it's totally variable?
There was a problem hiding this comment.
I have a custom prefix and good to have this issue to know where should I look for in valet. thanks!
|
This fix only works for the contrib module. There is still #771 |
|
@chrfritsch Thanks for bringing that back up! I'd love for anyone who knows how this all works to PR in a fuller fix. |
This change fixes issues with using the JSON:API in Drupal.