Install older PHP versions via alternate tap #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Userland test results: #1407 (comment) |
mattstauffer
reviewed
May 5, 2023
cli/Valet/Brew.php
Outdated
| @@ -135,10 +145,14 @@ public function installOrFail(string $formula, array $options = [], array $taps | |||
| } | |||
|
|
|||
| output('<info>['.$formula.'] is not installed, installing it now via Brew...</info> 🍻'); | |||
| if ($formula !== 'php' && starts_with($formula, 'php') && preg_replace('/[^\d]/', '', $formula) < '73') { | |||
| if ($formula !== 'php' && starts_with($formula, 'php') && preg_replace('/[^\d]/', '', $formula) < '81') { | |||
There was a problem hiding this comment.
Should we possibly move 81 here into a const so we can remember to check that regularly too?
There was a problem hiding this comment.
Since it's just displaying an informational message, ima merge it with the newly-added array constant, since both are actually quite tightly linked. And it's harmless if it shows the message but was wrong, since instead of 10 minutes it'll be 10 seconds, and nobody will be offput by that 🤷♂️
There was a problem hiding this comment.
I added a test as well
drbyte
force-pushed
the
install-via-alt-tap
branch
from
d1d2e1b to
92fe7a7
Compare
Fixes laravel#1407 Homebrew's support policy now aggressively disables older versions earlier than it did previously. That is why we tap the `shivammathur/php` repository. But since Homebrew also now "keeps" those old formulae but marks them as disabled, when Valet runs `brew install [email protected]` it fails because Homebrew just aborts due to its flags in the outdated formula. (They mark it as "disabled" and/or "keg_only :versioned_formula", but don't actually delete the formula from their repository.) To override that we must use `brew install shivammathur/php/[email protected]` internally. Therefore, we need to maintain a list of which PHP Versions we wish to specifically prefix with the `shivammathur/php` tap in order to bypass Homebrew's flags. **ANNUAL MAINTENANCE** 1. This PR adds the array of `LIMITED_PHP_VERSIONS` which we will have to update annually when new PHP versions are retired as others are released. 2. We should also annually update the `LATEST_PHP_VERSION` string.
drbyte
force-pushed
the
install-via-alt-tap
branch
from
92fe7a7 to
615d61d
Compare
|
Fantastic! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1407
Homebrew's support policy now aggressively disables older versions earlier than it did previously. That is why we tap the
shivammathur/phprepository.But since Homebrew also now "keeps" those old formulae but marks them as disabled, when Valet runs
brew install [email protected]it fails because Homebrew just aborts due to its flags in the outdated formula. (They mark it as "disabled" and/or "keg_only :versioned_formula".) To override that we must usebrew install shivammathur/php/[email protected]internally.Therefore, we need to maintain a list of which PHP Versions we wish to specifically prefix with the
shivammathur/phptap in order to bypass Homebrew's flags.ANNUAL MAINTENANCE
LIMITED_PHP_VERSIONSwhich we will have to update annually when new PHP versions are retired as others are released.LATEST_PHP_VERSIONstring.