Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update php and composer commands to allow passing in specific site #1370

Merged
merged 1 commit into from
Feb 19, 2023

Conversation

mattstauffer
Copy link
Collaborator

@mattstauffer mattstauffer commented Feb 17, 2023

Closes #1367.

E.g., to run this command:

valet php -v

When you've linked a site using a name other than the directory name; for example:

cd /tmp
mkdir my-site
cd my-site
valet link different-name-than-folder
valet isolate different-name-than-folder [email protected]

This PR allows you to run this:

valet php --site=different-name-than-folder -v

cli/app.php Show resolved Hide resolved
cli/app.php Show resolved Hide resolved
@scrummitch
Copy link

Working locally for me, test output here:

#1367 (comment)

@mattstauffer mattstauffer merged commit 9782d48 into master Feb 19, 2023
@mattstauffer mattstauffer deleted the mes/php-site-param branch February 19, 2023 02:46
mattstauffer added a commit that referenced this pull request Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

valet php can't be defined to run on a site linked to a name different than its directory
3 participants