Make 127.0.0.1 SERVER_ADDR definition only if null #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattstauffer
force-pushed
the
mes/conditional-127-0-0-1
branch
from
6b0560a to
cb30b65
Compare
mattstauffer
force-pushed
the
mes/conditional-127-0-0-1
branch
from
cb30b65 to
6437faa
Compare
Merged
vinkla
added a commit
to vinkla/wordplate
that referenced
this pull request
Jan 31, 2023
mattstauffer
added a commit
that referenced
this pull request
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BasicValetDriverand a few drivers which extend it set theSERVER_ADDRto127.0.0.1. To be honest, I'm not sure what circumstance actually requires this.Here's the PR that introduced it, which doesn't tell us much: #380
So, in order to support local network sharing in #1284, I'm going to make what I hope a very narrow change that sets it to
127.0.0.1only if it'snull. It doesn't break any tests and doesn't break my environment, so hopefully I'm understanding correctly that this is workable.I originally wrote this using
??=but we're stuck on PHP 7.2+.