[WIP] Multiple/Parallel PHP Version Support for Valet -- Updated #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Matt Stauffer <[email protected]>
Co-authored-by: Matt Stauffer <[email protected]>
Co-authored-by: Matt Stauffer <[email protected]>
Co-authored-by: Matt Stauffer <[email protected]>
|
@NasirNobin I made some updates to your PR, including moving the isolation into its own command, which you can see here. I'll likely make a new branch where I attempt to do the symlink change we talked about in the PR, so it doesn't mess this one up. if you have time and you're interested, please feel free to review this PR, or just wait until I work on the symlink change (which I'm not getting to tonight, I don't think). |
Handle "[email protected]" Simplify the entire method into one block Co-Authored-By: Nathan Morgan <[email protected]>
…to mes/symlink-valet-socks
1 task
driesvints
reviewed
Mar 14, 2022
| 'php73', | ||
| 'php72', | ||
| 'php71', | ||
| 'php70', | ||
| 'php56', |
There was a problem hiding this comment.
This probably requires a new major version release?
There was a problem hiding this comment.
@driesvints Yah.. good call, thank you.
- Fix the isolated directories test given new table shape - Updated useVersion test to no longer hit the real filesystem Co-Authored-By: Jacob Baker-Kretzmar <[email protected]>
…to mes/symlink-valet-socks
Co-Authored-By: Jacob Baker-Kretzmar <[email protected]>
…ng PHP-FPM Co-Authored-By: Jacob Baker-Kretzmar <[email protected]>
Co-Authored-By: Jacob Baker-Kretzmar <[email protected]>
Update `valet.sock` to be a symlink to an existing `valet{version}.sock` file
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm building on #1192 and needed to make a PR from a local working branch so I can push code to it. More details soon.