Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace HTTPFul with Guzzle #1163

Merged
merged 2 commits into from
Dec 21, 2021
Merged

Conversation

bram-pkg
Copy link
Contributor

@bram-pkg bram-pkg commented Dec 20, 2021

As commented on #1157, HTTPful contains some deprecated calls and replacing it with Guzzle is better.

@mattstauffer
Copy link
Collaborator

@bram-pkg Thank you so much for this PR!!

@mattstauffer mattstauffer merged commit 465bdaa into laravel:master Dec 21, 2021
@bram-pkg bram-pkg deleted the replace-httpful branch December 21, 2021 14:00
@driesvints
Copy link
Member

@bram-pkg fyi: we fixed a small issue with this PR here: #1164

@driesvints
Copy link
Member

@bram-pkg seems that there's more issues with this PR:

Fatal error: Uncaught Error: Call to undefined method GuzzleHttp\Utils::jsonDecode() in /Users/driesvints/.composer/vendor/laravel/valet/cli/Valet/Valet.php:81

Guzzle v6 doesn't have this. I'll try to fix this.

@driesvints
Copy link
Member

Released v2.18.3 with a fix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants