Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ngrok binary to latest version v2.3.40 #1082

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

devfrey
Copy link
Contributor

@devfrey devfrey commented Aug 6, 2021

Today when trying valet share the following error popped up:

$ valet share --region=eu
Your ngrok agent version "2.3.35" is no longer supported. Only the most recent version of the ngrok agent is supported without an account.
Update to a newer version with ngrok update or by downloading from https://ngrok.com/download.
Sign up for an account to avoid forced version upgrades: https://ngrok.com/signup.
ERR_NGROK_120

This PR updates the ngrok binary to the latest stable version.

Maybe we should also look into supporting the M1 binary for non-Intel macs. But that's outside of the scope of this PR.

@drbyte
Copy link
Contributor

drbyte commented Aug 6, 2021

I'm puzzled why your ngrok isn't auto-updating itself.

Mine does this:
Screen Shot 2021-08-06 at 1 18 54 PM
and then about 3 seconds later this:
Screen Shot 2021-08-06 at 1 18 59 PM
and then on subsequent restarts of ngrok via valet share it shows normally like this:
Screen Shot 2021-08-06 at 1 20 20 PM

That said, I've no objection to upgrading the default binary distributed with Valet again. It's been awhile.

@mattstauffer
Copy link
Collaborator

Mine requires me to hit CTRL-U to update; did you do that, Chris?

image

I'll merge and release this, based on your response. Thanks as always!

@mattstauffer mattstauffer merged commit 40d96af into laravel:master Aug 9, 2021
@devfrey devfrey deleted the update-ngrok branch August 9, 2021 15:26
@drbyte
Copy link
Contributor

drbyte commented Aug 9, 2021

Mine requires me to hit CTRL-U to update; did you do that, Chris?

image

Good point. Mine is set to auto-update via my ~/.ngrok2/ngrok.yml file, but the CTRL+U option is fine too.

authtoken: (redacted)

#docs: https://ngrok.com/docs

region: us

json_resolver_url: ""
dns_resolver_ips: []

# root_cas options: trusted, host, or path-to-a-CA-file
root_cas: trusted

# auto-update
update: true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants