[4.x] Remove guzzlehttp/guzzle ~5.0 workaround #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. This package has required Composer dependency `"guzzlehttp/guzzle": "~6.0"` since Socialite 3.0 and Laravel 5.4 (2017 January 15) 811a744#diff-b5d0ee8c97c7abd7e3fa29b9a27d1780 2. guzzlehttp/guzzle 7.x removes property `GuzzleHttp\ClientInterface::VERSION`: https://github.com/guzzle/guzzle/blob/master/UPGRADING.md#60-to-70 This removes code no longer called that will cause issues when dependencies are updated to `"guzzlehttp/guzzle": "^6.3|^7.0"` like laravel/framework's 6.x & 7.x has now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There still exists a
"~5.0|~6.0"workaround for Guzzle 6.0 replacing the'body'option with'form_params'.'form_params'key is used so the Guzzle 5'body'key fallback can be removed."guzzlehttp/guzzle"7.x removes theGuzzleHttp\ClientInterface::VERSIONproperty being used to select which Guzzle option key to use.This removes code no longer called that will cause issues when dependencies are updated to
"guzzlehttp/guzzle": "^6.3|^7.0"like"laravel/framework"'s 6.x & 7.x branches have configured.