Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Http
class inSlackWebhookChannel
Why?
Short version: testability.
Longer version:
This issue was the trigger for me: when running tests that use an old webhook-style integration, you will be presented with
Error using Illuminate\Notifications\Slack\SlackMessage buildJsonPayload
errors.In my particular case, I do not have the ability to overrride
routeNotificationFor
because I am not triggering my notification from a model, but am doing it as so:I tried overriding the config in the tests to point to
https://hook.slack.com
but then we are presented with a 404 page, without an easy ability to mock this URL.Hence, this is why using the native Http client from Laravel is preferred: we can just mock this request from our tests and be done, and all is well again in the world.
Tests
Tests have been updated to reflect this change.