[PHP 8.1] Avoid running string functions when domain is null #258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue in PHP 8.1 where a request with no
Referer
orOrigin
header will throw a deprecation warning (transformed to anErrorException
in tests) whenStr::replaceFirst
attempts to callstrpos
withnull
as the first argument.Once PHP 8.1 is added to the matrix, this will be automatically covered by
test_requests_are_not_stateful_without_referer
.Context:
Stacktrace