more performant tokens lookup

laravel · May 4, 2020 · 5ce9e05 · 5ce9e05 · Nitwix · Apr 5, 2024
1 parent 51e401e
commit 5ce9e05
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 3 deletions.
diff --git a/src/HasApiTokens.php b/src/HasApiTokens.php
@@ -49,7 +49,7 @@ public function createToken(string $name, array $abilities = ['*'])
             'abilities' => $abilities,
         ]);
 
-        return new NewAccessToken($token, $plainTextToken);
+        return new NewAccessToken($token, $token->id.'|'.$plainTextToken);
     }
 
     /**

diff --git a/src/PersonalAccessToken.php b/src/PersonalAccessToken.php
@@ -55,7 +55,15 @@ public function tokenable()
      */
     public static function findToken($token)
     {
-        return static::where('token', hash('sha256', $token))->first();
+        if (! strpos($token, '|')) {
+            return static::where('token', hash('sha256', $token))->first();
+        }
+
+        [$id, $token] = explode('|', $token);
+
+        if ($instance = static::find($id)) {
+            return $instance->token == hash('sha256', $token) ? $instance : null;
+        }
     }
 
     /**

diff --git a/tests/HasApiTokensTest.php b/tests/HasApiTokensTest.php
@@ -15,9 +15,16 @@ public function test_tokens_can_be_created()
 
         $newToken = $class->createToken('test', ['foo']);
 
+        [$id, $token] = explode('|', $newToken->plainTextToken);
+
         $this->assertEquals(
             $newToken->accessToken->token,
-            hash('sha256', $newToken->plainTextToken)
+            hash('sha256', $token)
+        );
+
+        $this->assertEquals(
+            $newToken->accessToken->id,
+            $id
         );
     }
-Original file line number
+Diff line change
@@ Expand Up @@
                 'abilities' => $abilities,
             ]);
-            return new NewAccessToken($token, $plainTextToken);
+            return new NewAccessToken($token, $token->id.'|'.$plainTextToken);
         }
         /**
@@ Expand Down @@