Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PNPM support to enhance dependency management efficiency #605

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

SamuelMTeixeira
Copy link
Contributor

This PR aims to add support for PNPM in the Laravel development environment. PNPM is an alternative to npm and Yarn, designed to optimize the process of installing and managing dependencies.

The reason is because it brings a number of benefits, most notably improved project performance through optimized resource utilization. By efficiently using shared packages, PNPM significantly reduces disk space consumption. Its extremely fast installation times result from dependency linking, while cache efficiency and low memory consumption contribute to an overall smoother development experience.
This will result in Laravel projects that are lighter and faster to download.

I have also omitted the command && npm install -g npm \ as it is unnecessary. The Node image already includes the latest version of npm during the extraction process. This refinement simplifies configuration and ensures that the development environment has an up-to-date version of npm without redundancy.

@driesvints
Copy link
Member

I really don't think we should be replacing NPM with this...

@SamuelMTeixeira
Copy link
Contributor Author

I really don't think we should be replacing NPM with this...

It's not exactly replace, but adding another valid option. In the same way we have yarn support as well.

@driesvints
Copy link
Member

@SamuelMTeixeira you're removing the update to NPM. Just let that line stay?

@SamuelMTeixeira
Copy link
Contributor Author

@SamuelMTeixeira you're removing the update to NPM. Just let that line stay?

Of course!

@taylorotwell taylorotwell merged commit e5536ac into laravel:1.x Aug 14, 2023
@wblondel
Copy link

Hello @SamuelMTeixeira ,

I noticed that PNPM support was added only in the PHP 8.2 image Dockerfile. Was it intentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants