Revert "Expose 8080 port for hot module replacement" #432
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #391
As detailed at #391 (comment), Laravel Mix no longer works inside or outside the container without additional Mix configuration. If the user already needs to manually configure Mix, then they might as well just configure this part of their
docker-compose.yml
manually as well.Please note that a similar feature for Vite is being added to Sail in #433, however it does not suffer the same issue because Laravel's first-party Vite plugin will automatically detect when it's inside Sail and will listen on the appropriate host. Additionally, Vite will automatically find an available port when the default is in use, and the Laravel plugin will add the correct port to the
public/hot
file, allowing Vite to be used both in and outside the container with no additional configuration.