Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MySQL shell when running mariadb #119

Merged
merged 2 commits into from
Apr 29, 2021
Merged

Add MySQL shell when running mariadb #119

merged 2 commits into from
Apr 29, 2021

Conversation

SamuelMwangiW
Copy link
Contributor

@SamuelMwangiW SamuelMwangiW commented Apr 29, 2021

Add option to Access the mysql shell when running mariadb in place of mysql service.

Running sail mysql is a very helpful tool to access mysql shell.
With the addition of support for mariadb in #119 it would be really awesome to accord mariadb users to a similar experience.

This PR adds support to run: sail mariadb and access the good old MySQL shell.
image

Running sail mysql when running mariadb fails with the error ERROR: No such service: mysql

Add option to Access the mysql shell when running mariadb in place of mysql service
@SamuelMwangiW
Copy link
Contributor Author

I appreciate that a more intuitive option would have been to hook onto the mysql parameter but this is a more cleaner approach imo

@taylorotwell taylorotwell merged commit bb6590b into laravel:1.x Apr 29, 2021
@SamuelMwangiW SamuelMwangiW deleted the patch-1 branch April 29, 2021 16:42
oddvalue pushed a commit to oddvalue/sail that referenced this pull request May 26, 2021
* Add MySQL shell when running mariadb

Add option to Access the mysql shell when running mariadb in place of mysql service

* Update sail

Co-authored-by: Taylor Otwell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants