Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Allow publishing to others only when using Redis #275

Merged
merged 5 commits into from
Nov 27, 2024

Conversation

larswolff
Copy link
Contributor

Pass SocketID through redis, and filter it on the receiving end.

This ensures that ->toOthers() works with scaling = true

Pass SocketID through redis, and filter it on the receiving end.

This ensures that ->toOthers() works with scaling = true
@larswolff
Copy link
Contributor Author

I have no idea how to fix this unit test mock error.

@joedixon joedixon changed the title Fix for issue #246 [1.x] Allow publishing to others only when using Redis Nov 27, 2024
Copy link
Collaborator

@joedixon joedixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed broken test and added a new test. Thank you!

Resolves #246

@taylorotwell taylorotwell merged commit c312511 into laravel:main Nov 27, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants