Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] mergeConfigFrom() already check if app is running with config cached. #1205

Merged
merged 1 commit into from
Mar 20, 2020

Conversation

crynobone
Copy link
Member

@crynobone crynobone commented Mar 20, 2020

@crynobone crynobone changed the title [8.x] mergeConfigFrom() already check if app is running with config c… [8.x] mergeConfigFrom() already check if app is running with config cached. Mar 20, 2020
Copy link

@Exotelis Exotelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@driesvints driesvints merged commit efae7be into laravel:8.x Mar 20, 2020
@driesvints
Copy link
Member

Thanks!

@crynobone crynobone deleted the patch-2 branch March 20, 2020 11:45
@lloricode
Copy link

Hi @driesvints, can you set tag with this?

Thank you

@driesvints
Copy link
Member

@lloricode release day is today

@driesvints
Copy link
Member

FYI: we don't officially support using Passport with Lumen. Please consider migrating to Laravel.

@Exotelis
Copy link

FYI: we don't officially support using Passport with Lumen. Please consider migrating to Laravel.

I'd like to mention that if you just want to build an API without sessions and all these stuff, lumen is the right choice. laravel/passwort work perfectly with Lumen when you use the dusterio/lumen-passport package, even after the upgrade to 7.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants