Use Facade::resolved() before extending passport guard. #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[7.0] Fix incorrect comment in TokenGuard::getTokenViaCookie
# Conflicts: # composer.json # tests/HandlesOAuthErrorsTest.php
This allows alternative implementation of `auth` to be able to use with passport without hacking around PackageManifest. Based on PR made to laravel/framework#26824 Signed-off-by: Mior Muhammad Zaki <[email protected]>
|
@crynobone please try to branch off from master next time, this pr merged all commits from 7.0 into master. |
|
@crynobone nvm, Taylor pointed out your comment to me. Sorry about that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows alternative implementation of
authto be able to use with passport without hacking around PackageManifest.Based on PR made to laravel/framework#26824
Also I did merge
7.0code tomastersince it quite outdated. Including this fix still missing onmasterbranch f583d11