Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined array key "assets" #864

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Fix undefined array key "assets" #864

merged 2 commits into from
Mar 26, 2024

Conversation

sy-records
Copy link
Contributor

@sy-records sy-records commented Mar 26, 2024 •
edited
Loading

Failure to fetch assets due to API rate limit exceeded, The RequestException will now be thrown.

image

close #863

@smortexa
Copy link
Contributor

IMO, it should throw HTTP request exception here.

@taylorotwell taylorotwell merged commit 605401e into laravel:2.x Mar 26, 2024
11 of 12 checks passed
@sy-records sy-records deleted the fix/assets branch March 26, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smortexa smortexa smortexa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undefined array key "assets"
3 participants
@sy-records @smortexa @taylorotwell