Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support roadrunner http v3 #688

Merged

Conversation

cappuc
Copy link
Contributor

@cappuc cappuc commented Apr 28, 2023

This PR adds support for spiral/roadrunner-http v3

The spiral/roadrunner now is a meta package and does not require spiral/roadrunner-http anymore, so I've changed the requirements to spiral/roadrunner-http (and spiral/roadrunner-cli which is required to download the roadrunner binary) instead of spiral/roadrunner.

The other required change is the configuration version, that must be set to 3 for the new version, and is set dynamically based on roadrunner binary version

@rustatian
Copy link

Here's what has changed in the v3 configuration (most of the changes are not related to octane): https://roadrunner.dev/docs/plugins-config/2023.x/en#v30-configuration

@nunomaduro nunomaduro changed the base branch from 1.x to feat/roadrunner-v3 May 1, 2023 10:46
@nunomaduro nunomaduro merged commit 1e6f795 into laravel:feat/roadrunner-v3 May 1, 2023
@nunomaduro
Copy link
Member

Going to merge this on my own pull request, so I can run some tests locally. I will let you know how it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants