Add --rpc-host option for Roadrunner
#619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds the
--rpc-hostoption to be used for the Roadrunner server. Its value defaults to the--hostoption to preserve backward compatibility.Why
When deploying to AWS ECS as a Docker container and Nginx sidecar, the
--hostoption must be set to0.0.0.0to listen to any host.However, the RPC host needs to be set to the loopback interface
127.0.0.1. The current logic sets both hosts to the same, making this impossible to configure.We've already implemented this as a custom command on our own codebase, which has been deployed to a production environment and is successfully working as we expect.
Without this, we get a bunch of
network errorlogs and the task is never able to start due to the server being unable to respond to any requests: