Prefix rr binary permissions with 0 to specify it as an octal value #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Dylan-Buth please see the pr template and don't just link to an issue. Provide a thorough explanation why this is needed for the person who will review this. |
|
@driesvints Updated the description |
|
Is it released? |
|
Release day is on Tuesday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the issue described here.
On php 8.1 octane errors out because it's unable to start the rr binary that gets downloaded. It's unable to because it doesn't have permission, because the
chmod()that gets run after the binary is installed, doesn't have the right value for permissions. It's trying to set them to755but per the chmod documentation, you need to use a0prefix to specify it as an octal value.This PR adds the
0prefix to the permissions, setting them to0755which runs successfully on php 8.1.