[1.x] Fix carbon locale when setting it via app locale setter #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 25, 2022
|
briannesbitt/Carbon#2640 released in 2.60.0 |
|
Thanks @kylekatarnls! |
driesvints
reviewed
Jul 28, 2022
taylorotwell
deleted the
fix/carbon-locale-when-setting-it-via-app-locale-setter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the last issue regarding the "locale" update on Vapor apps.
So, the first, got fixed here: #552. And it was regarding the any call to "Carbon::setLocale()" actually changing the local for subsequent requests.
The second, is this one, and concerns the fact that "app->setLocale()" is actually setting the locale of the "app" running the server, and not the app handling the request.
As discussed with Carbon's maintainer, we need the releasing of Carbon, before merging and tagging this pull request: briannesbitt/Carbon#2640.
Fixes #551.
PS: Ignore the tests for now, and I will update this, once the Carbon release is ready.