Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PaginationState to resolve using new instance of the app #519

Merged
merged 2 commits into from
May 13, 2022

Conversation

farmani
Copy link
Contributor

@farmani farmani commented May 12, 2022

based on our experience PaginationState will use different instance (old instance) of the app and cannot recognize new parameter has been set in the route it seems this was implemented before but commented out.

this PR revert them back but in Listener class it was using sandbox not sure what was the reason I change it to app

@taylorotwell taylorotwell merged commit e40447b into laravel:1.x May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants