Give the current App instance to FilesystemManager #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlexVanderbist this PR broke our build. Can you send in a fix? Otherwise it might be best we revert this for now. |
|
Looking at it right now! Saw the failing test and didn't think it would get merged 😅 |
|
@AlexVanderbist it's always best to place your PR in draft when it's not finished yet. I know the build indicates it's not passing but sometimes, like now, we can miss that. |
|
@driesvints that's my bad! Wasn't failing locally so didn't realise until it was too late. Got a fix ready in #459 tho :) |
|
@AlexVanderbist Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FilesystemManagerand its custom/extended drivers rely on the$filesystemManager->appinstance to provide the app config. If the config changes at runtime (e.g. multi-tenancy environment or via a package service provider) theFilesystemManagerkeeps using the old application instance and the wrong config values.This PR uses laravel/framework#40058 to fix this issue. A test is included and the
laravel/frameworkversion is bumped to make sure theFilesystemManager::setApplication()method from the aforementioned PR is always available.