Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Avoids usage of SWOOLE_SSL when openssl is not configured on swoole #357

Merged
merged 2 commits into from
Aug 5, 2021

Conversation

nunomaduro
Copy link
Member

This pull request addresses an issue where SWOOLE_SSL constant was being used even if the openssl was not configured on swoole causing the following error: Undefined constant SWOOLE_SSL.

With this pull request, the SWOOLE_SSL is only used if the user have enabled openssl on swoole and configured octane to use ssl.

@nunomaduro nunomaduro requested a review from taylorotwell August 5, 2021 13:02
@nunomaduro nunomaduro changed the title Avoids usage of SWOOLE_SSL when openssl is not configured on swoole [1.x] Avoids usage of SWOOLE_SSL when openssl is not configured on swoole Aug 5, 2021
@taylorotwell taylorotwell merged commit 64a1c3c into 1.x Aug 5, 2021
@taylorotwell taylorotwell deleted the fix/undefined-swoole-ssl branch August 5, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants