[10.x] throw file-system exceptions by default #6030
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd personally vote against this breaking change as it'd involve a lot of changes to existing apps that use the filesystem. |
|
@driesvints The exceptions are still configurable, and can be disabled to reduce the change need to upgrade to v10 |
|
@ankurk91 that's true. |
|
We can think about this closer to release but there hasn't been a huge demand for it or anything. |
|
@taylorotwell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref laravel/framework#41308
Laravel 8 used to throw file-system excretions but
Laravel 9 changed this behaviour and made it configurable instead.
This PR brings back the Laravel 8 behaviour and throw exceptions by default.
I think most of Laravel 9 developers are living in dark and unknown about this behaviour.
Exceptions are good :)