[4.x] Fix Browser Sessions not showing platform and browser #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
crynobone
approved these changes
Nov 29, 2023
|
nice, thanks for sorting out the tests 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browser Sessions are currently showing '1-1' when they should be displaying 'Platform - Browser', the image below shows reality/expected behaviour.
#1399 used the cache implemented in
mobiledetect/mobiledetectlibwhich only supportsboolvalues. As multiple calls toagent->platform()andagent->browser()are made in the component the cache is engaged and produces boolean values instead of the expected strings.This pull request replaces the
mobiledetectcache implementation with a simple key value store on theAgentclass.Current tests pass as the first call to
agent->platform()andagent->browser()do not hit the cache. Hopefully I will have time tomorrow to update the tests too.I am not sure if this is the ideal solution or if the
mobiledetectcache should be reimplemented to support mixed values. I briefly considered using the Laravel cache, but considering this data is only stored for the request lifecycle it seemed a little over the top.