Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Revert #820 #831

Merged
merged 1 commit into from
Apr 21, 2020
Merged

[4.x] Revert #820 #831

merged 1 commit into from
Apr 21, 2020

Conversation

themsaid
Copy link
Member

This PR reverts #820 which broke deployments on Envoyer.

@taylorotwell taylorotwell merged commit 03feeb6 into laravel:4.x Apr 21, 2020
@liamcottle
Copy link

I was pulling the last of my hair out for hours trying to figure out why horizon:terminate was not killing Horizon on new code deploys to Forge via Envoyer.

Manually SSH'ing in to the queue server and running the horizon:terminate command sometimes worked, (shown at the top of the screenshot) and sometimes just returned no response at all, and the same horizon supervisors were still running, (shown near the bottom of the screenshot).

I was able to restart Horizon by restarting the daemon manually through the Forge UI, but this wasn't a good solution.

After updating Horizon from 4.3.0 to 4.3.1, the issue has been fixed for me, thanks!

Here's a screenshot of what was happening before the fix. 😅
Screen Shot 2020-04-23 at 7 49 02 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants