fix: undefined array key 'queue' #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some crashes in
MasterSupervisorController.In fact, it seems like in the case where
$valueis an array that has noqueuekey, it's failing because we are still trying to access this key.I think the parenthesis were probably added by mistake, as coalescing ( ?? ) operator cannot be applied "directly" on
$value['queue'].For reproducing matter, I don't really know how to reproduce it, it seems like it sometimes enters in this code, but not always. And in fact we are not running any queued job in the route where it fails, maybe some redis usage around session or cache, but no custom application queued jobs that could trigger horizon, so it is quite mysterious for me.