Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artisan command "cache:clear" #660

Merged

Conversation

franzliedke
Copy link
Contributor

This implements #31.

Taylor: Do we need a unit test for this? It's pretty trivial.

@taylorotwell
Copy link
Member

Looks pretty good. I would just lump the service provider in with CacheServiceProvider with a registerCommands method. Also, I think after the flush we should unlink the $config['app.manifest'] file so the services.json file is re-built as well on next request.

@franzliedke
Copy link
Contributor Author

I'll do that - I had put it there because that's how you had done it for the session:tablecommand.

And haha, I had wondered whether I should ask again about the manifest file, but when I tested this on a local app, it picked up my service provider changes without complaining...

@franzliedke
Copy link
Contributor Author

Ah, I see. It only worked because I had created a new service provider. Changing an existing one will not work. Fix is coming.

@franzliedke
Copy link
Contributor Author

Done, Taylor. Want unit tests, too? (That the manifest gets removed, too, basically.)

@franzliedke
Copy link
Contributor Author

Ok, my bad. Actually tested now.

taylorotwell added a commit that referenced this pull request Mar 25, 2013
@taylorotwell taylorotwell merged commit 5b3d04e into laravel:master Mar 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants