Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.x] Use reject() instead of a negated filter() #53925

Merged
merged 1 commit into from
Dec 16, 2024
Merged

[12.x] Use reject() instead of a negated filter() #53925

merged 1 commit into from
Dec 16, 2024
+6 −6

Conversation

shaedrich
Copy link
Contributor

No description provided.

@taylorotwell taylorotwell merged commit 8660d95 into laravel:master Dec 16, 2024
40 checks passed
@browner12
Copy link
Contributor

I would argue against this and say negated filters are better because they have a simpler call stack.

@shaedrich
Copy link
Contributor Author

To achieve this, you would have to remove the reject() method entirely, but this isn't possible 🤷🏻

@shaedrich shaedrich deleted the fix-negated-filter-reject branch December 16, 2024 17:16
@browner12
Copy link
Contributor

huh? we could just not use this change.

@taylorotwell obviously the impact is minor, but did you merge for improved readability? thoughts on the tradeoff with the increased call stack?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaedrich @browner12 @taylorotwell