Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.x] Simplify conditional returns #53920

Closed
wants to merge 3 commits into from
Closed

[12.x] Simplify conditional returns #53920

wants to merge 3 commits into from
+25 −38

Conversation

shaedrich
Copy link
Contributor

Reducing five lines to three each

(Inspired by #53918)

@shaedrich shaedrich changed the title early return to enum [12.x] early return to enum Dec 16, 2024
@shaedrich shaedrich changed the title [12.x] early return to enum [12.x] early return to ternary Dec 16, 2024
@dennisprudlo
Copy link
Contributor

Is this really necessary? The next PR will be reducing the 3 lines to 1 by putting everything in one line...

@shaedrich
Copy link
Contributor Author

I let Taylor be the judge of that

@shaedrich shaedrich changed the title [12.x] early return to ternary [12.x] Simplify conditional returns Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaedrich @dennisprudlo @taylorotwell