[11.x] Remove duplicated method call from if-else construct

[shaedrich]

static::factoryForModel($relatedModel) is called twice

Alternative considerations

Other considerations:

-       if (method_exists($relatedModel, 'newFactory')) {
-           $factory = $relatedModel::newFactory() ?? static::factoryForModel($relatedModel);
+       if (method_exists($relatedModel, 'newFactory') && ($factory = $relatedModel::newFactory()) !== null) {
+           //
        } else {
            $factory = static::factoryForModel($relatedModel);
        }

-       if (method_exists($relatedModel, 'newFactory')) {
-           $factory = $relatedModel::newFactory() ?? static::factoryForModel($relatedModel);
+       if (method_exists($relatedModel, 'newFactory') && ($_factory = $relatedModel::newFactory()) !== null) {
+           $factory = $_factory;
        } else {
            $factory = static::factoryForModel($relatedModel);
        }

(Inspired by #53902)

[taylorotwell]

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!