[11.x] No need to redeclare variables #53887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crynobone
added a commit
that referenced
this pull request
Dec 17, 2024
This reverts commit 69284e3.
taylorotwell
pushed a commit
that referenced
this pull request
Dec 17, 2024
joostdebruijn
added a commit
to joostdebruijn/framework
that referenced
this pull request
Dec 18, 2024
This reverts commit 69284e3.
|
I wanted to create a Pull Request which would add a test to cover the error occurred in the I don't really see how to easily add a test for this behaviour. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the ServeCommand class by eliminating redundant redeclarations of variables, such as repeated instantiations of Stringable. Instead, a single $stringable variable is reused throughout the method. This change simplifies the code, improves readability, and slightly optimizes performance by avoiding repeated object creation.